[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices
- To: "Eduardo Habkost" <ehabkost@xxxxxxxxxx>
- From: "Jan Beulich" <JBeulich@xxxxxxxx>
- Date: Thu, 28 Sep 2017 02:33:57 -0600
- Cc: Peter Maydell <peter.maydell@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx, Gerd Hoffmann <kraxel@xxxxxxxxxx>, David Gibson <dgibson@xxxxxxxxxx>, Jiri Slaby <jslaby@xxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Alberto Garcia <berto@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Alexander Graf <agraf@xxxxxxx>, Hervé Poussineau <hpoussin@xxxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Richard Henderson <rth@xxxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, Marcel Apfelbaum <marcel@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Laine Stump <laine@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Yongbok Kim <yongbok.kim@xxxxxxxxxx>, Alistair Francis <alistair23@xxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Igor Mammedov <imammedo@xxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>
- Delivery-date: Thu, 28 Sep 2017 08:34:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
>>> On 27.09.17 at 21:56, <ehabkost@xxxxxxxxxx> wrote:
> --- a/hw/xen/xen_pt.c
> +++ b/hw/xen/xen_pt.c
> @@ -964,6 +964,10 @@ static const TypeInfo xen_pci_passthrough_info = {
> .instance_size = sizeof(XenPCIPassthroughState),
> .instance_finalize = xen_pci_passthrough_finalize,
> .class_init = xen_pci_passthrough_class_init,
> + .interfaces = (InterfaceInfo[]) {
> + { INTERFACE_CONVENTIONAL_PCI_DEVICE },
> + { },
> + },
> };
Passed through devices can be both PCI and PCIe, so following
the description of the patch I don't think these can be statically
given either property. Granted quite a bit of PCIe specific
functionality may be missing in the Xen code ...
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
