Re: [Xen-devel] [PATCH 01/27 v10] xen/arm: vpl011: Define common ring buffer helper functions in console.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.09.17 at 10:16, <bhupinder.thakur@xxxxxxxxxx> wrote:
> On 26 September 2017 at 12:45, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 26.09.17 at 01:08, <bhupinder.thakur@xxxxxxxxxx> wrote:
>>> Yes, after including the __STRICT_ANSI__ check the headers.chk check
>>> passes. But I had to include string header file (after suggestion from
>>> Stefano) for fixing the headers++.chk.
>>
>> I'd like to have a more detailed explanation here - since the header
>> passed the check without this prereq before, I'd prefer if the
>> dependency was not added unconditionally.
> 
> The C header passed the check without the prereq addition. However,
> for C++ headers since
> __STRICT_ANSI__ is not defined, it tries to expand the
> DEFINE_XEN_FLEX_RING macro
> and looks for declarations for size_t, memcpy() etc. To satisfy that
> requirement, string header
> file had to included similar to what was done for pvcalls.

Ah, yes. This should equally apply to the C99 check then.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel