Re: [Xen-devel] [PATCH v5 09/23] x86/mm: add pv prefix to {set, destroy}_gdt

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.09.17 at 14:58, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/pv/mm.h
> +++ b/xen/include/asm-x86/pv/mm.h
> @@ -25,14 +25,24 @@
>  
>  int pv_ro_page_fault(unsigned long addr, struct cpu_user_regs *regs);
>  
> +long pv_set_gdt(struct vcpu *d, unsigned long *frames, unsigned int entries);
> +void pv_destroy_gdt(struct vcpu *d);
> +
>  #else
>  
> +#include <xen/errno.h>
> +
>  static inline int pv_ro_page_fault(unsigned long addr,
>                                     struct cpu_user_regs *regs)
>  {
>      return 0;
>  }
>  
> +static inline long pv_set_gdt(struct vcpu *d, unsigned long *frames,
> +                              unsigned int entries)
> +{ return -EINVAL; }
> +static inline void pv_destroy_gdt(struct vcpu *d) {}

Please everywhere here switch the parameter names from d to v.
With that and again maybe ASSERT_UNREACHABLE() added to the
stubs
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel