Re: [Xen-devel] [PATCH 06/27 v10] xen/arm: vpl011: Add a new domctl API to initialize vpl011

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.09.17 at 10:23, <bhupinder.thakur@xxxxxxxxxx> wrote:
> @@ -119,6 +144,33 @@ long arch_do_domctl(struct xen_domctl *domctl, struct 
> domain *d,
>          d->disable_migrate = domctl->u.disable_migrate.disable;
>          return 0;
>  
> +    case XEN_DOMCTL_vuart_op:
> +    {
> +        int rc;
> +        unsigned int i;
> +        struct xen_domctl_vuart_op *vuart_op = &domctl->u.vuart_op;
> +
> +        /* check that structure padding must be 0. */
> +        for ( i = 0; i < sizeof(vuart_op->pad); i++ )
> +            if ( vuart_op->pad[i] )
> +                return -EINVAL;

This could be had with less than half the amount of code if the
padding field was uint16_t. But anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel