Re: [Xen-devel] [PATCH 06/27 v9] xen/arm: vpl011: Add a new domctl API to initialize vpl011

[Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>]

Hi Jan,

On 18 September 2017 at 16:15, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 18.09.17 at 12:31, <bhupinder.thakur@xxxxxxxxxx> wrote:
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -36,6 +36,7 @@
>>  #include "grant_table.h"
>>  #include "hvm/save.h"
>>  #include "memory.h"
>> +#include "event_channel.h"
>
> Please play by the alphabetic sorting here (xen.h going first being
> the acceptable exception, albeit it doesn't really need explicitly
> including here).
I will rearrange it alphabetically.

>
>> @@ -1160,9 +1161,28 @@ struct xen_domctl_psr_cat_op {
>>      uint32_t target;    /* IN */
>>      uint64_t data;      /* IN/OUT */
>>  };
>> +
>>  typedef struct xen_domctl_psr_cat_op xen_domctl_psr_cat_op_t;
>
> Stray addition of a blank line.
ok. I will remove it.

>
>>  DEFINE_XEN_GUEST_HANDLE(xen_domctl_psr_cat_op_t);
>>
>> +struct xen_domctl_vuart_op {
>
> Please have a comment ahead of this mentioning the XEN_DOMCTL_*
> to use with this structure, like many (but sadly not all) structures
> have.
>
ok.

>> +#define XEN_DOMCTL_VUART_OP_INIT  0
>> +        uint32_t cmd;           /* XEN_DOMCTL_VUART_OP_* */
>> +#define XEN_DOMCTL_VUART_TYPE_VPL011 0
>> +        uint32_t type;          /* IN - type of vuart.
>> +                                 *      Currently only vpl011 supported.
>> +                                 */
>> +        uint64_aligned_t  gfn;  /* IN - guest gfn to be used as a
>> +                                 *      ring buffer.
>> +                                 */
>> +        domid_t console_domid;  /* IN */
>
> And this one's different from the domid in the domctl header? It's
> certainly odd that this is the only field without any meaningful
> comment...
Yes this domid is of the domain running the backend console. I need it to setup
the event channel between the guest domain and the domain running the
backend console.

I will add a comment explaining the parameter.

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel