Re: [Xen-devel] [RFC PATCH V3 1/3] Xen: Increase hap/shadow page pool size to support more vcpus support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.09.17 at 10:50, <tianyu.lan@xxxxxxxxx> wrote:
> On 2017年09月20日 23:13, Wei Liu wrote:
>> On Tue, Sep 19, 2017 at 11:06:26AM +0800, Lan Tianyu wrote:
>>> Hi Wei:
>>>
>>> On 2017年09月18日 21:06, Wei Liu wrote:
>>>> On Wed, Sep 13, 2017 at 12:52:47AM -0400, Lan Tianyu wrote:
>>>>> This patch is to increase page pool size when max vcpu number is larger
>>>>> than 128.
>>>>>
>>>>> Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx>
>>>>> ---
>>>>>  xen/arch/arm/domain.c    |  5 +++++
>>>>>  xen/arch/x86/domain.c    | 25 +++++++++++++++++++++++++
>>>>>  xen/common/domctl.c      |  3 +++
>>>>>  xen/include/xen/domain.h |  2 ++
>>>>>  4 files changed, 35 insertions(+)
>>>>>
>>>>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>>>>> index 6512f01..94cf70b 100644
>>>>> --- a/xen/arch/arm/domain.c
>>>>> +++ b/xen/arch/arm/domain.c
>>>>> @@ -824,6 +824,11 @@ int arch_vcpu_reset(struct vcpu *v)
>>>>>      return 0;
>>>>>  }
>>>>>  
>>>>> +int arch_domain_set_max_vcpus(struct domain *d)
>>>>> +{
>>>>> +    return 0;
>>>>> +}
>>>>> +
>>>>>  static int relinquish_memory(struct domain *d, struct page_list_head 
>>>>> *list)
>>>>>  {
>>>>>      struct page_info *page, *tmp;
>>>>> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
>>>>> index dbddc53..0e230f9 100644
>>>>> --- a/xen/arch/x86/domain.c
>>>>> +++ b/xen/arch/x86/domain.c
>>>>> @@ -1161,6 +1161,31 @@ int arch_vcpu_reset(struct vcpu *v)
>>>>>      return 0;
>>>>>  }
>>>>>  
>>>>> +int arch_domain_set_max_vcpus(struct domain *d)
>>>>
>>>> The name doesn't match what the function does.
>>>>
>>>
>>> I originally hoped to introduce a hook for each arch when set max vcpus.
>>> Each arch function can do customized thing and so named
>>> "arch_domain_set_max_vcpus".
>>>
>>> How about "arch_domain_setup_vcpus_resource"?
>> 
>> Before you go away and do a lot of work, please let us think about if
>> this is the right approach first.
> 
> Sure. This idea that increase page pool when set max vcpu is from Jan.
> Jan, Could you help to check whether current patch is right approach?

Whenever I get to it, sure. What I can say right away is that I
agree with the comment about the name of the function.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel