Re: [Xen-devel] [PATCH v2 03/21] libxl/xl: use the new domain_build_info fields position

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v2 03/21] libxl/xl: use the new 
domain_build_info fields position"):
> This is required because those options will be used by the new PVH
> guest type, and thus need to be shared between PV and HVM.
...
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 02ddd2e90d..61f9a38573 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -1037,6 +1037,65 @@ void parse_config_data(const char *config_source,
>      xlu_cfg_get_defbool(config, "driver_domain", &c_info->driver_domain, 0);
>      xlu_cfg_get_defbool(config, "acpi", &b_info->acpi, 0);
>  
> +    xlu_cfg_replace_string (config, "bootloader", &b_info->bootloader, 0);
> +    switch (xlu_cfg_get_list_as_string_list(config, "bootloader_args",
> +                                            &b_info->bootloader_args, 1)) {

The code motion would benefit from being moved into a pre-patch.  Is
that easily possible ?  Obviously in the new location, in the
pre-patch it would still need to be in an if () to check the guest
type.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel