Re: [Xen-devel] [PATCH 01/12] arm/acpi: switch to plain bool

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 09/15/2017 10:42 AM, Wei Liu wrote:
> diff --git a/xen/include/asm-arm/acpi.h b/xen/include/asm-arm/acpi.h
> index 9f954d39e1..a62429e7e2 100644
> --- a/xen/include/asm-arm/acpi.h
> +++ b/xen/include/asm-arm/acpi.h
> @@ -43,8 +43,8 @@ typedef enum {
>       TBL_MMAX,
>   } EFI_MEM_RES;
>   
> -bool_t __init acpi_psci_present(void);
> -bool_t __init acpi_psci_hvc_present(void);
> +bool __init acpi_psci_present(void);
> +bool __init acpi_psci_hvc_present(void);
>   void __init acpi_smp_init_cpus(void);
>   
>   /*
> @@ -57,16 +57,16 @@ void __init acpi_smp_init_cpus(void);
>   paddr_t acpi_get_table_offset(struct membank tbl_add[], EFI_MEM_RES index);
>   
>   #ifdef CONFIG_ACPI
> -extern bool_t acpi_disabled;
> +extern bool acpi_disabled;
>   /* Basic configuration for ACPI */
>   static inline void disable_acpi(void)
>   {
> -    acpi_disabled = 1;
> +    acpi_disabled = true;
>   }
>   
>   static inline void enable_acpi(void)
>   {
> -    acpi_disabled = 0;
> +    acpi_disabled = false;
>   }
>   #else
>   #define acpi_disabled (1)
Can you modify the 1 to true, here? This would make the !CONFIG_ACPI 
version inlined with the CONFIG_ACPI one.
With that:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel