Re: [Xen-devel] [PATCH v5 4/8] xen: make grant resource limits per domain

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.09.17 at 12:40, <jgross@xxxxxxxx> wrote:
> On 08/09/17 17:44, Jan Beulich wrote:
>>>>> On 08.09.17 at 08:56, <jgross@xxxxxxxx> wrote:
>>> @@ -3755,6 +3763,12 @@ static void gnttab_usage_print(struct domain *rd)
>>>  
>>>      grant_read_lock(gt);
>>>  
>>> +    printk("grant-table for remote domain:%5d (v%d)\n"
>>> +           "  %d frames (%d max), %d maptrack frames (%d max)\n",
>>> +           rd->domain_id, gt->gt_version,
>>> +           nr_grant_frames(gt), gt->max_grant_frames,
>>> +           nr_maptrack_frames(gt), gt->max_maptrack_frames);
>> 
>> Various %u instances again, and Dom%d please. Also you put this
>> after the table header, corrupting intended output.
> 
> The position where the domain header is printed didn't change. It is
> just unconditional now and contains some more information.

Oh, indeed, it's sort of malformed even before your change.

>>> @@ -3782,12 +3796,7 @@ static void gnttab_usage_print(struct domain *rd)
>>>              status = status_entry(gt, ref);
>>>          }
>>>  
>>> -        if ( first )
>>> -        {
>>> -            printk("grant-table for remote domain:%5d (v%d)\n",
>>> -                   rd->domain_id, gt->gt_version);
>>> -            first = 0;
>>> -        }
>>> +        first = 0;
>> 
>> Is it useful to print the per-table information when there are no
>> entries at all for a domain? I think it would be better to move
>> what you add as well as the table header into the if() that you
>> delete.
> 
> Hmm, I think the per-domain limits are valuable even without any
> grant entries being present. In the end I don't expect lots of domains
> without any grant entry other than dom0, as the default entries for
> xenstore and console are being created by the tools already. And having
> dom0 information especially for the maptrack entries will be
> interesting.

Okay, valid point.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel