Re: [Xen-devel] [PATCH] monitor: switch to plain bool

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 08/09/17 14:44, Wei Liu wrote:
> diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c
> index a7ccfc4b42..b534dd3043 100644
> --- a/xen/arch/x86/hvm/monitor.c
> +++ b/xen/arch/x86/hvm/monitor.c
> @@ -30,7 +30,7 @@
>  #include <asm/vm_event.h>
>  #include <public/vm_event.h>
>  
> -bool_t hvm_monitor_cr(unsigned int index, unsigned long value, unsigned long 
> old)
> +bool hvm_monitor_cr(unsigned int index, unsigned long value, unsigned long 
> old)
>  {
>      struct vcpu *curr = current;
>      struct arch_domain *ad = &curr->domain->arch;
> @@ -41,7 +41,7 @@ bool_t hvm_monitor_cr(unsigned int index, unsigned long 
> value, unsigned long old
>            value != old) &&
>           (!((value ^ old) & ad->monitor.write_ctrlreg_mask[index])) )
>      {
> -        bool_t sync = !!(ad->monitor.write_ctrlreg_sync & ctrlreg_bitmask);
> +        bool sync = !!(ad->monitor.write_ctrlreg_sync & ctrlreg_bitmask);

You can drop the !! and brackets.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel