Re: [Xen-devel] [PATCH] x86/page: Implement {get, set}_pte_flags() as static inlines

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Sep 07, 2017 at 02:39:57PM +0100, Andrew Cooper wrote:
> This resolves 11 Coverity issues along the lines of the following:
> 
> 1600        for ( i = 0; i < NR_RESERVED_GDT_PAGES; i++ )
> 
>     CID: Operands don't affect result
>     (CONSTANT_EXPRESSION_RESULT)result_independent_of_operands: ((33U /* 1U |
>     0x20U */) | (({...}) ? 8388608U /* 1U << 23 */ : 0) | 0x40U | 2U) & 4095
>     is always 0x63 regardless of the values of its operands. This occurs as
>     the bitwise second operand of "|".
> 
> 1601            l1e_write(pl1e + FIRST_RESERVED_GDT_PAGE + i,
> 1602                      l1e_from_pfn(mfn + i, __PAGE_HYPERVISOR_RW));
> 
> This is presumably because once preprocessed, the association of joint logic
> inside {get,set}_pte_flags() is lost.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel