Re: [Xen-devel] [PATCH 22/27 v8] xen/arm: vpl011: Add support for vuart console in xenconsole

[Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>]

On 5 September 2017 at 15:01, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Mon, Sep 04, 2017 at 09:58:07PM +0530, Bhupinder Thakur wrote:
>> Hi Jan,
>>
>>
>> On 28 August 2017 at 14:41, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> >>>> On 28.08.17 at 10:56, <bhupinder.thakur@xxxxxxxxxx> wrote:
>> >> --- a/config/arm32.mk
>> >> +++ b/config/arm32.mk
>> >> @@ -1,5 +1,6 @@
>> >>  CONFIG_ARM := y
>> >>  CONFIG_ARM_32 := y
>> >> +CONFIG_VUART_CONSOLE := y
>> >>  CONFIG_ARM_$(XEN_OS) := y
>> >>
>> >>  CONFIG_XEN_INSTALL_SUFFIX :=
>> >> diff --git a/config/arm64.mk b/config/arm64.mk
>> >> index aa45772..861d0a4 100644
>> >> --- a/config/arm64.mk
>> >> +++ b/config/arm64.mk
>> >> @@ -1,5 +1,6 @@
>> >>  CONFIG_ARM := y
>> >>  CONFIG_ARM_64 := y
>> >> +CONFIG_VUART_CONSOLE := y
>> >>  CONFIG_ARM_$(XEN_OS) := y
>> >
>> > I think this wants to be solved better than by starting to again
>> > introduce CONFIG_* values here.
>>
>> I think I can remove this flag from here since it is used currently
>> for xenconsole only to enable VUART console support for ARM. I can
>> directly define the flag in the tools/console Makefile based on
>> CONFIG_ARM option.
>
> Just use CONFIG_ARM directly?

I believe I cannot use CONFIG_ARM directly in
tools/console/daemon/io.c as it is a makefile variable.

Currently, in tools/console/Makefile the VUART specifc flag is
included like this:

CFLAGS_vuart-$(CONFIG_VUART_CONSOLE) = -DCONFIG_VUART_CONSOLE

I will change it to:

CFLAGS_vuart-$(CONFIG_ARM) = -DCONFIG_VUART_CONSOLE

and remove CONFIG_VUART_CONSOLE variable from arm32.mk and arm64.mk.

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel