Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jul 18, 2017 at 05:25:20PM +0300, Oleksandr Grytsov wrote:
> From: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
> 
> Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
> ---
>  tools/libxl/Makefile                 |   2 +-
>  tools/libxl/libxl.h                  |  24 +++
>  tools/libxl/libxl_create.c           |   1 +
>  tools/libxl/libxl_internal.h         |   1 +
>  tools/libxl/libxl_types.idl          |  38 ++++-
>  tools/libxl/libxl_types_internal.idl |   1 +
>  tools/libxl/libxl_utils.h            |   4 +
>  tools/libxl/libxl_vdispl.c           | 289 
> +++++++++++++++++++++++++++++++++++

Only skim-read this patch because changes are rather self-contained.

> +static int libxl__device_vdispl_getconnectors(libxl_ctx *ctx,
> +                                              const char *path,
> +                                              libxl_vdisplinfo *info)
> +{
> +    GC_INIT(ctx);
> +    char *connector = NULL;
> +    char *connector_path = NULL;
> +    int i, rc;
> +
> +    GCNEW_ARRAY(connector_path, 128);

Using char[128] should be fine.

> +
> +    info->num_connectors = 0;
> +
> +    rc = snprintf(connector_path, 128, "%s/%d", path, info->num_connectors);
> +    if (rc < 0) goto out;
> +
> +    while((connector = xs_read(ctx->xsh, XBT_NULL, connector_path, NULL))

Coding style.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel