Re: [Xen-devel] [PATCH 1/2] Fix util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Mon, Aug 28, 2017 at 02:42:18PM -0400, Konrad Rzeszutek Wilk wrote:
> On Mon, Aug 28, 2017 at 02:40:14PM -0400, Konrad Rzeszutek Wilk wrote:
> > Commit d33045ce7ffcb7c1e4a60c14d5ca64b36e3c5abe introduced
> > the support for this, but it does not work under x86 (as it stops
> > 20_linux_xen from running).
> >
> > The 20_linux_xen is run under a shell and any exits from within it:
> >
> > (For example on x86):
> > + /usr/bin/grub2-file --is-arm64-efi /boot/xen-4.9.0.gz
> > [root@tst063 grub]# echo $?
> > 1
> >
> > will result in 20_linux_xen exciting without continuing

s/exciting/exiting/?

> > and also causing grub2-mkconfig to stop processing.
> >
> > As in:
>
> git format-patch decided to eat this relevant part:
>
> [root@tst063 grub]# ./grub-mkconfig | tail
> Generating grub configuration file ...
> Found linux image: /boot/vmlinuz-4.13.0-0.rc5.git1.1.fc27.x86_64
> Found initrd image: /boot/initramfs-4.13.0-0.rc5.git1.1.fc27.x86_64.img
> Found linux image: /boot/vmlinuz-0-rescue-ec082ee24aea41b9b16aca52a6d10cc2
> Found initrd image: 
> /boot/initramfs-0-rescue-ec082ee24aea41b9b16aca52a6d10cc2.img
>               echo    'Loading Linux 
> 0-rescue-ec082ee24aea41b9b16aca52a6d10cc2 ...'
>               linux   /vmlinuz-0-rescue-ec082ee24aea41b9b16aca52a6d10cc2 
> root=/dev/mapper/fedora_tst063-root ro single
>               echo    'Loading initial ramdisk ...'
>               initrd  /initramfs-0-rescue-ec082ee24aea41b9b16aca52a6d10cc2.img
>       }
> }
>
> ### END /usr/local/etc/grub.d/10_linux ###
>
> ### BEGIN /usr/local/etc/grub.d/20_linux_xen ###
>
> root@tst063 grub]#

In general LGTM. Though please repost this patch with full commit message?

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel