Re: [Xen-devel] [PATCH RFC 2/2] x86/mm: PG_translate implies PG_refcounts

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Aug 24, 2017 at 11:09:38AM +0100, Andrew Cooper wrote:
> On 24/08/17 11:07, Wei Liu wrote:
> > On Thu, Aug 24, 2017 at 11:05:36AM +0100, Wei Liu wrote:
> >> On Thu, Aug 24, 2017 at 11:02:33AM +0100, Tim Deegan wrote:
> >>> At 16:58 +0100 on 23 Aug (1503507504), Wei Liu wrote:
> >>>> After 404595352 ("x86/paging: Enforce PG_external == PG_translate ==
> >>>> PG_refcounts"), PG_refcounts and PG_translate always need to be set
> >>>> together.
> >>>>
> >>>> Squash PG_refcounts to simplify code. All calls paging_mode_refcounts
> >>>> are replaced by calls to paging_mode_translate.
> >>> Would it be a good idea to merge all three and have only PG_external?
> >>>
> >> My reverse-engineering is that when PV guest is migrated it has
> >> PG_external and (the new) PG_translate.
> > Sorry, I meant (!PG_external && PG_translate)
> 
> PV guests migrating should get logdirty and none of
> PG_external|PG_translate|PG_refcounts
> 

OK, in that case I will squash PG_external as well.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel