Re: [Xen-devel] [PATCH 25/27] xen/arm: mm: Embed permission in the flags

[Julien Grall <julien.grall@xxxxxxx>]

On 08/23/2017 03:08 PM, Andre Przywara wrote:
> Hi,
Hi,

> On 14/08/17 15:24, Julien Grall wrote:
> > Currently, it is not possible to specify the permission of a new
> > mapping. It would be necessary to use the function modify_xen_mappings
> > with a different set of flags.
> >
> > Add introduce a couple of new flags for the permissions (Non-eXecutable,
> > Read-Only) and also provides define that combine the memory attribute
> > and permission for common combination.
> If I haven't been lost in the definitions, this now adds "not
> executable" to the existing definitions, which seems to make sense, but
> is a change that might trigger regressions (especially for
> PAGE_HYPERVISOR). So I wonder if that should be mentioned in the commit
> message then?
It will not trigger regression because mfn_to_xen_entry is setting xn to 
1 by default. So all the mapping will be execute never when using 
PAGE_HYPERVISOR.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel