Re: [Xen-devel] [PATCH V2 7/25] tools/libacpi: Add new fields in acpi_config for DMAR table

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Aug 23, 2017 at 10:36:45AM +0800, Lan Tianyu wrote:
> On 2017年08月22日 21:12, Wei Liu wrote:
> > On Wed, Aug 09, 2017 at 04:34:08PM -0400, Lan Tianyu wrote:
> >> From: Chao Gao <chao.gao@xxxxxxxxx>
> >>
> >> The BIOS reports the remapping hardware units in a platform to system 
> >> software
> >> through the DMA Remapping Reporting (DMAR) ACPI table.
> >> New fields are introduces for DMAR table. These new fields are set by
> >> toolstack through parsing guest's config file. construct_dmar() is added to
> >> build DMAR table according to the new fields.
> >>
> >> Signed-off-by: Chao Gao <chao.gao@xxxxxxxxx>
> >> Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx>
> >> ---
> >>  tools/libacpi/build.c   | 57 
> >> +++++++++++++++++++++++++++++++++++++++++++++++++
> >>  tools/libacpi/libacpi.h |  9 ++++++++
> >>  2 files changed, 66 insertions(+)
> >>
> >> diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c
> >> index f9881c9..c7cc784 100644
> >> --- a/tools/libacpi/build.c
> >> +++ b/tools/libacpi/build.c
> >> @@ -28,6 +28,10 @@
> >>  
> >>  #define ACPI_MAX_SECONDARY_TABLES 16
> >>  
> >> +#define VTD_HOST_ADDRESS_WIDTH 39
> >> +#define I440_PSEUDO_BUS_PLATFORM 0xff
> >> +#define I440_PSEUDO_DEVFN_IOAPIC 0x0
> > 
> > I have some stupid questions. What are these I440 values? Where do they
> > come from?
> > 
> 
> Each IOAPIC device in the system reported via ACPI MADT must be
> explicitly enumerated under one specific remapping hardware unit. We
> assigned IOAPCI unit to bdf ff:00 and referenced Qemu vIOMMU implementation.

OK, do they need to be somewhere in a public header?

(See Roger's comment in the other sub-thread)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel