Re: [Xen-devel] [PATCH V2 3/25] VIOMMU: Add get irq info callback to convert irq remapping request

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Aug 09, 2017 at 04:34:04PM -0400, Lan Tianyu wrote:
> This patch is to add get_irq_info callback for platform implementation
> to convert irq remapping request to irq info (E,G vector, dest, dest_mode
> and so on).
> 
> Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx>
> ---
>  xen/common/viommu.c          | 16 ++++++++++++++++
>  xen/include/asm-x86/viommu.h |  8 ++++++++
>  xen/include/xen/viommu.h     |  9 +++++++++
>  3 files changed, 33 insertions(+)
> 
> diff --git a/xen/common/viommu.c b/xen/common/viommu.c
> index f4d34e6..03c879d 100644
> --- a/xen/common/viommu.c
> +++ b/xen/common/viommu.c
> @@ -213,6 +213,22 @@ int viommu_handle_irq_request(struct domain *d, u32 
> viommu_id,
>      return info->viommu[viommu_id]->ops->handle_irq_request(d, request);
>  }
>  
> +int viommu_get_irq_info(struct domain *d, u32 viommu_id,

Again, uint32_t please.

Please fix all these in this series.

> +                        struct irq_remapping_request *request,
> +                        struct irq_remapping_info *irq_info)
> +{
> +    struct viommu_info *info = &d->viommu;

Having skimmed the rest of this series, there is no addition of viommu
to struct domain (no change to sched.h). Did I miss something obvious?

> +
> +    if ( viommu_id >= info->nr_viommu
> +         || !info->viommu[viommu_id] )
> +        return -EINVAL;
> +
> +    if ( !info->viommu[viommu_id]->ops->get_irq_info )
> +        return -EINVAL;
> +
> +    return info->viommu[viommu_id]->ops->get_irq_info(d, request, irq_info);

Same comments in previous patch apply here, too.

> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/include/asm-x86/viommu.h b/xen/include/asm-x86/viommu.h
[...]
> +static inline int viommu_get_irq_info(struct domain *d, u32 viommu_id,
> +                                      struct irq_remapping_request *request,
> +                                      struct irq_remapping_info *irq_info)
> +{ return 0 };

This should fail, too.

>  #endif
>  
>  #endif /* __XEN_VIOMMU_H__ */
> -- 
> 1.8.3.1
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel