[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 48/52] xen: add hypercall for setting parameters at runtime


  • To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
  • Date: Wed, 9 Aug 2017 12:56:36 -0400
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Wed, 09 Aug 2017 16:57:07 +0000
  • Ironport-phdr: 9a23:Cgt/2RTHjocKHZYrUUQfSIlzpNpsv+yvbD5Q0YIujvd0So/mwa67ZxCOt8tkgFKBZ4jH8fUM07OQ6PGwHzRYqb+681k6OKRWUBEEjchE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i764jEdAAjwOhRoLerpBIHSk9631+ev8JHPfglEnjSwbLdxIRmssQndqtQdjJd/JKo21hbHuGZDdf5MxWNvK1KTnhL86dm18ZV+7SleuO8v+tBZX6nicKs2UbJXDDI9M2Ao/8LrrgXMTRGO5nQHTGoblAdDDhXf4xH7WpfxtTb6tvZ41SKHM8D6Uaw4VDK/5KpwVhTmlDkIOCI48GHPi8x/kqRboA66pxdix4LYeZyZOOZicq/Ye94VS3BBXsJMXCJfBI2yYZYEA+4YMepGs4Xxol0Dpga8CwaxHuPi0iJGiGH43aM61OQvEg/I0wIvEN0MrHvao874NLsQXO2v0KXE0TvOYvFQ1Dzg6IbIaBchofSUULx+a8XRz0gvGB3Bjl6Np4LqIS6e2OUXs2eB9eVgW/+khmk6pAF+vzeg2MgsipPTiY8O1lDF9Tl2wIYyJdGiTk57esSrHIFftyGdKYt7W8UvSHxrtiYi0rAKpJG2cScQxJkn2hLTceKLfoeW7h75SeqcJypzimh/d7KlnRmy9FCtyuj7VsapzllHtjFFktzQtnAV0BzT99SHRuN9/ki/3TaP0Bje6v1eLkAulKrbNoUhzqQslpsTrUvDHij2lF/wjKCKbUUr5vKk6+HmYrXivpOcNol0hR/iMqk2h8CyDus1PhIOUmSG4+iwyrLu8VPjTLlXlvE2l7PWsJHeJcQVvK65BApV354+5BawEjipztsYnWMdI19eZBKGj5TmO1HJIPziC/e/mE6jnC1kx/DBIL3tGo/NIWTbkLf9YbZ97FZRyAg8zdBF4JJUEaoBLenoWk/sr9zXEAU1PBCzw+biEN99zJ8RWXqTAq+FN6PfqVCJ6fwpI+WVeYAapij9JOYh5/P1iX85mEQdfbWy3ZcNZ3G3APJmL1+eYXr2jdcLCX0KsRYmTOz2lF2CViZeZ3eoUKI6/D07CpipApvARoC2h7yB2jy2EYNLZmxcFl+MEGvod5+FW/YDci6dPshhkjkcX7i7V4AhzQ2utBP9y7d/IOvb5CwYuYjn1Nh0+u3fiwo/+iB1D8SByWGNTm51knkUSD8x2aB1uVZ9xUub0ahkn/xYEsRe6OlPUggnL57T0eJ7B8ruVQLGedeJUEipQs+oDDwqUt0xwsMOY1x8G9StlBzMwy2qA7oNnbyRGJM06r7c32T2J8tlynjJyq4hj0MpQsRRL2GoiLN/9w7XB4HTi0WUjLildbkG0CHR9WeD0XCOvEBXUQJqTarFWnUfbFPMrdvl/kPCU6OuCbM/PwtD0sGNNLZKatnojVpaRPfuI8/eY3+qm2iuHxqH2rSMbI/ycWUHwCrdEFQEkxwU/XueNgg+ASGho3jEAzNzD17ubULs8e19qH6gSU801RuFYFFl17Wr4BIamfucS/YL1LIepCghsyl0HEq639/OENqAvBZhc79Hbtwj5FdH0WPZtwp8PpG7LKBtmEQecwJpsEPqzRl3DZ9AkccypnMw0AVyMb6Y0E9Gdz6AwZDwO7jXJ3L9/R+xba7awFbe0MyZ+vRH1PNtiUjupg6kEAIN6XJ8yJEB0XSG4Y7RJBEPSp+3WUEyoVwyt7zcJyUw+Y7Q/XltKrWv9C/P3ZQuHuR25AyneoJzOaWFGQu6P8BSKNKnIeJiz1SmYh8LJul66L8/P8TgceCPnqGsIrAzz3qdkW1b7dUlgQq3/C1mR7uNhsxdzg==
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 08/09/2017 03:07 AM, Juergen Gross wrote:
Add a sysctl hypercall to support setting parameters similar to
command line parameters, but at runtime. The parameters to set are
specified as a string, just like the boot parameters.

Looks good, except for one thing:

+    case XEN_SYSCTL_set_parameter:
+        return domain_has_xen(current->domain, XEN2__SET_PARAMETER);

This needs to use SECCLASS_XEN2, but domain_has_xen uses SECCLASS_XEN.
I will be sending a patch fixing the other two incorrect users above
in that switch statement.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.