Re: [Xen-devel] [RFC PATCH v3 21/24] ARM: NUMA: ACPI: Extract proximity from SRAT table

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 18/07/17 12:41, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
>
> Register SRAT entry handler for type
> ACPI_SRAT_TYPE_GICC_AFFINITY to parse SRAT table
> and extract proximity for all CPU IDs.
>
> Signed-off-by: Vijaya Kumar <Vijaya.Kumar@xxxxxxxxxx>
Please split this patch in multiple chunk. The addition in the ACPI 
common code should at least be separated.
[...]

> diff --git a/xen/include/asm-arm/numa.h b/xen/include/asm-arm/numa.h
> index 0d3146c..f0a50bd 100644
> --- a/xen/include/asm-arm/numa.h
> +++ b/xen/include/asm-arm/numa.h
> @@ -7,6 +7,15 @@ void dt_numa_process_memory_node(uint32_t nid, paddr_t start, 
> paddr_t size);
>  void register_node_distance(uint8_t (fn)(nodeid_t a, nodeid_t b));
>  void init_dt_numa_distance(void);
>
> +#ifdef CONFIG_ACPI_NUMA
> +nodeid_t acpi_get_nodeid(uint64_t hwid);
> +#else
> +static inline nodeid_t acpi_get_nodeid(uint64_t hwid)
> +{
> +    return 0;
> +}
> +#endif /* CONFIG_ACPI_NUMA */
Do you expect CONFIG_ACPI_NUMA to be disabled when ACPI is supported on ARM?

> +
>  #ifdef CONFIG_NUMA
>  void numa_init(void);
>  int dt_numa_init(void);
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel