Re: [Xen-devel] [OSSTEST PATCH v13 18/24] TestSupport: Introduce target_cmd_stashed

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Jul 25, 2017 at 07:26:07PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[OSSTEST PATCH v13 18/24] TestSupport: Introduce 
> target_cmd_stashed"):
> > This works like target_cmd, but takes a ref to a filename as argument
> > and stash the output of the command then return a path to the stashed
> > output.
> ...
> > +# Like target_cmd, but stash cmd stdout and return a path to it.
> > +sub target_cmd_stashed ($$$;$$) {
> > +    my ($tho,$leafref,$tcmd,$timeout,$extrasshopts) = @_;
> > +    my $stdout = open_unique_stashfile($leafref);
> > +    my $rc = tcmd(undef, $stdout, 0, 'osstest', $tho, $tcmd, $timeout,
> > +        $extrasshopts);
> > +    die "$stdout $!" if $stdout->error or !close $stdout;
> 
> You can't sensibly interpolate a filehandle into a "" string.
> You should use the filename (probably, the whole filename).

Right, I did not think about that. I've just copy/past the line from the
function tcmdout(). I'll use the filename.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel