Re: [Xen-devel] [PATCH 4/7] xen: credit2: soft-affinity awareness in csched2_cpu_pick()

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On Tue, Jul 25, 2017 at 12:04 PM, George Dunlap
<george.dunlap@xxxxxxxxxx> wrote:
> On 06/16/2017 03:14 PM, Dario Faggioli wrote:
>> We want to find the runqueue with the least average load,
>> and to do that, we scan through all the runqueues.
>>
>> It is, therefore, enough that, during such scan:
>> - we identify the runqueue with the least load, among
>>   the ones that have pcpus that are part of the soft
>>   affinity of the vcpu we're calling pick on;
>> - we identify the same, but for hard affinity.
>>
>> At this point, we can decide whether to go for the
>> runqueue with the least load among the ones with some
>> soft-affinity, or overall.
>>
>> Therefore, at the price of some code reshuffling, we
>> can avoid the loop.
>>
>> (Also, kill a spurious ';' in the definition of MAX_LOAD.)
>>
>> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
>> Signed-off-by: Justin T. Weaver <jtweaver@xxxxxxxxxx>
>
> Looks good:
>
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Er, sorry, this was supposed to be for patch 5...

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel