Re: [Xen-devel] [PATCH v6 18/20] osstest: hook FreeBSD flight into cr-daily-branch

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v6 18/20] osstest: hook FreeBSD flight into 
cr-daily-branch"):
> Add the missing pieces so that cr-daily-branch knows how to create a
> FreeBSD flight. This has been tested by calling `./cr-daily-branch
> freebsd-master`.
...
> +TREE_FREEBSD=$PUSH_TREE_FREEBSD

PUSH_TREE_FREEBSD seems not to be defined.  Have I missed something ?
Likewise BASE_TREE_FREEBSD.

> +     cd $repos/freebsd
> +     git push $TREE_FREEBSD $revision:refs/heads/$branchcore

We don't normally call the osstest output branch for trees which are
managed by someone else, "master".  Maybe we want another name ?
Especially if this is going into xenbits's toplevel - but maybe it
isn't.

Apart from that this looks OK, but of course it probably needs a call
to mg-anoint.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel