Re: [Xen-devel] [PATCH v6 17/20] osstest: introduce a script to create a FreeBSD flight

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v6 17/20] osstest: introduce a script to create 
a FreeBSD flight"):
> Changes since v5:
>  - Append the "freebsd" hostflag, the specific version will be set
>    dynamically by the ts-freebsd-set-hostflags script.

I think we discussed using PropMinVer ?
I'm not sure what the generic versionless "freebsd" hostflag is for.

> +for arch in "$arches"; do
> +    set_freebsd_runvars
> +    job_create_build build-$arch-freebsd build-freebsd                    \
   \
> +                arch=$arch                                                \
   \
> +                $RUNVARS $BUILD_RUNVARS $BUILD_FREEBSD_RUNVARS $arch_runva\
rs \
> +                tree_freebsd=$TREE_FREEBSD                                \

Please rewrap.  The current width causes wrap damage when quoted.

Aside from those two comments, this LGTM.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel