Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

[Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>]

Hi Stefano,


>>  CONFIG_ARM := y
>>  CONFIG_ARM_32 := y
>> +CONFIG_VUART_CONSOLE := y
>>  CONFIG_ARM_$(XEN_OS) := y
>>
>>  CONFIG_XEN_INSTALL_SUFFIX :=
>
> What about leaving this off for ARM32 by default?

I will disable it for ARM32.


>> -     if (!con->interface && xgt_handle) {
>> +     if (!con->interface &&
>> +         xgt_handle &&
>> +         con->prefer_gnttab) {
>>               /* Prefer using grant table */
>>               con->interface = xengnttab_map_grant_ref(xgt_handle,
>>                       dom->domid, GNTTAB_RESERVED_CONSOLE,
>
> I noticed that you removed the initialization of optional and
> prefer_gnttab from console_init from this patch:
>
> @@ -790,6 +817,8 @@ static int console_init(struct console *con, struct 
> domain *dom, void **data)
>       con->d = dom;
>       con->ttyname = (*con_data)->ttyname;
>       con->log_suffix = (*con_data)->log_suffix;
> +     con->optional = (*con_data)->optional;
> +     con->prefer_gnttab = (*con_data)->prefer_gnttab;
>       xsname = (*con_data)->xsname;
>       con->xspath = xs_get_domain_path(xs, dom->domid);
>       s = realloc(con->xspath, strlen(con->xspath) +
>
> Why? It that intended?

Thanks for noticing this. Actually while splitting the patch, this
change mistakenly moved to the previous patch. I will correct this.

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel