Re: [Xen-devel] [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage

[Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>]

On Wed, Jul 19, 2017 at 04:51:02PM +0200, Juergen Gross wrote:
> On 19/07/17 16:43, Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > 
> > It's better to be explicit and use the DRIVER_ATTR_RW() and
> > DRIVER_ATTR_RO() macros when defining a driver's sysfs file.
> > 
> > Bonus is this fixes up a checkpatch.pl warning.
> > 
> > This is part of a series to drop DRIVER_ATTR() from the tree entirely.
> > 
> > Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> 
> I'll take this through the Xen tree, unless you want to use your tree.

If I can take it through mine, then I could drop DRIVER_ATTR() from the
whole tree for the next kernel release, which would be ideal.

But if you want to take it, that's fine, I can wait another release, no
rush.

thanks,

greg k-h

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel