Re: [Xen-devel] [RFC PATCH v3 11/24] ARM: fdt: Export and introduce new fdt functions

[Julien Grall <julien.grall@xxxxxxx>]

On 18/07/17 16:29, Wei Liu wrote:
> On Tue, Jul 18, 2017 at 05:11:33PM +0530, vijay.kilari@xxxxxxxxx wrote:
> > From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
> >
> > Introduce new api device_tree_type_matches() to check for
> > device type. Also export device_tree_get_u32() and
> > device_tree_node_compatible()
> >
> > These functions are later used for parsing NUMA information.
> >
> > Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
> > ---
> > v3: Export device_tree_node_compatible() instead of
> >     device_tree_node_matches()
> > ---
> >  xen/arch/arm/bootfdt.c      | 20 ++++++++++++++++----
> >  xen/include/asm-arm/setup.h |  5 +++++
> >  2 files changed, 21 insertions(+), 4 deletions(-)
> >
> > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> > index ea188a0..6e8251b 100644
> > --- a/xen/arch/arm/bootfdt.c
> > +++ b/xen/arch/arm/bootfdt.c
> > @@ -31,8 +31,8 @@ static bool_t __init device_tree_node_matches(const void 
> > *fdt, int node,
> >          && (name[match_len] == '@' || name[match_len] == '\0');
> >  }
> >
> > -static bool_t __init device_tree_node_compatible(const void *fdt, int node,
> > -                                                 const char *match)
> > +bool_t __init device_tree_node_compatible(const void *fdt, int node,
> > +                                          const char *match)
> While you're changing the code please change bool_t to bool
+1.

Also, it is not necessary to CC all the people on every patches. Can you 
please use scripts/get_maintainers.pl to only CC relevant maintainers + 
people wanted to follow the series on each patch and not everyone 
everywhere...
>
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel