Re: [Xen-devel] [PATCH v4 14/16] osstest: add support for FreeBSD buildjobs to sg-run-job

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v4 14/16] osstest: add support for FreeBSD 
buildjobs to sg-run-job"):
> Add support and introduce a FreeBSD build job to sg-run-job.
...
>  proc allocate-build-host {ostype} {
>      global jobinfo
> +    if {[string equal $ostype FREEBSD]} {
> +        run-ts broken = ts-freebsd-set-hostflags
> +    }

I would prefer use of `switch' for this.  switch -exact $ostype etc.
Stylistically, please provide an explicit and empty default clause.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel