Re: [Xen-devel] [PATCH v4 11/16] osstest: introduce a script to set the runtime hostflags runvar for FreeBSD jobs

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v4 11/16] osstest: introduce a script to set 
the runtime hostflags runvar for FreeBSD jobs"):
> Due to the nature of the FreeBSD install media, which is
> self-generated from the ts-freebsd-build script, the hostflags runvar
> set to FreeBSD jobs are related to the current version under test.

This is good.  However:

> +set_runtime_hostflag("host",
> +                     "share-build-freebsd-$arch-$hash,freebsd-$version");

If you agree with my comments on the previous patch, you might want to
change this to two calls to set_runtime_hostflag, and to pass $ho.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel