Re: [Xen-devel] [PATCH 1/6] xen: Add support for hiding and unhiding pcie passthrough devices

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> > > --- a/xen/include/public/domctl.h
> > > +++ b/xen/include/public/domctl.h
> > > @@ -1222,6 +1222,9 @@ struct xen_domctl {
> > >  #define XEN_DOMCTL_gdbsx_pausevcpu             1001
> > >  #define XEN_DOMCTL_gdbsx_unpausevcpu           1002
> > >  #define XEN_DOMCTL_gdbsx_domstatus             1003
> > > +#define XEN_DOMCTL_hide_device                 2001
> > > +#define XEN_DOMCTL_unhide_device               2002
> > > +#define XEN_DOMCTL_test_hidden_device          2003
> > 
> > Why these strange numbers?
> 
> I saw the numbers jump from 79 to 1000 thru 1003, and likewise used
> different starting numbers. Would you prefer 80 thru 82, or 1004 thru

1000 are got gdbsx and the 2000 are reserved for OEM vendors.

So use 80 range.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel