Re: [Xen-devel] [PATCH v5 10/12] arm/mem_access: Add long-descriptor based gpt

[Sergej Proskurin <proskurin@xxxxxxxxxxxxx>]

Hi Julien,


[...]

>> +        /* Access the guest's memory to read only one PTE. */
>> +        ret = vgic_access_guest_memory(d, paddr, &pte,
>> sizeof(lpae_t), false);
>
> It really doesn't make sense to call a function vgic_* in guest page
> table walk code. I wasn't expected that I needed to explicitly say
> that vgic_access_* should be moved in ARM generic code and be renamed.

Do you think it would make sense to put the vgic_access_guest_memory
functionality into arch/arm/guestcopy.c? Alternatively I could introduce
a new file, such as guest-memory-access.c.

The same question applies to exporting the functionality in
include/asm-arm/guest_access.h or would you prefer a new header file
(e.g. guest-memory-access.h)?

Concerning the function name, I believe guest_memory_access() would be
appropriate.

Cheers,
~Sergej


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel