[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC



>>> Olaf Hering <olaf@xxxxxxxxx> 06/23/17 7:27 PM >>>
>--- a/tools/firmware/rombios/32bit/Makefile
>+++ b/tools/firmware/rombios/32bit/Makefile
>@@ -3,7 +3,7 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk
 >
 >TARGET = 32bitbios_flat.h
 >
>-CFLAGS += $(CFLAGS_xeninclude) -I.. -I../../../libacpi
>+CFLAGS += $(CFLAGS_xeninclude) -I.. -I../../../libacpi -fno-pic
 
In the description you also talk about PIE, but you deal with PIC only here. Is
that intentional? If so, please say why in the description.

Also, as to the Cc list - maintainership of rombios/ has recently changed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.