Re: [Xen-devel] [PATCH 1/7] xen: sched: factor affinity helpers out of sched_credit.c

[Anshul Makkar <anshul.makkar@xxxxxxxxxx>]

On 16/06/2017 15:13, Dario Faggioli wrote:
> In fact, we want to be able to use them from any scheduler.
>
> While there, make the moved code use 'v' for struct_vcpu*
> variable, like it should be done everywhere.
>
> No functional change intended.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> Signed-off-by: Justin T. Weaver <jtweaver@xxxxxxxxxx>
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> ---
> Cc: Anshul Makkar <anshul.makkar@xxxxxxxxxx>
> ---
>  xen/common/sched_credit.c  |   97 +++++++-------------------------------------
>  xen/include/xen/sched-if.h |   64 +++++++++++++++++++++++++++++
>  2 files changed, 79 insertions(+), 82 deletions(-)
>
> diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
> index efdf6bf..53773df 100644
> --- a/xen/common/sched_credit.c
> +++ b/xen/common/sched_credit.c
> @@ -136,27 +136,6 @@
*
> + * Hard affinity balancing is always necessary and must never be skipped.
> + * But soft affinity need only be considered when it has a functionally
> + * different effect than other constraints (such as hard affinity, cpus
> + * online, or cpupools).
> + *
> + * Soft affinity only needs to be considered if:
> + * * The cpus in the cpupool are not a subset of soft affinity
do you mean cpus in a cpupool are not in a subset of the soft affinity 
of a vcpu which is a runnable state ?
> + * * The hard affinity is not a subset of soft affinity
> + * * There is an overlap between the soft affinity and the mask which is
> + *   currently being considered.
> + */
reviewed !! looks good.

Anshul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel