Re: [Xen-devel] [PATCH v3 3/9] xen/mm: move modify_identity_mmio to global file and drop __init

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.06.17 at 15:10, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Jun 21, 2017 at 06:51:32AM -0600, Jan Beulich wrote:
>> Otoh
>> to prevent hangs we simply call process_pending_softirqs()
>> every once in a while in a few other cases, so maybe doing that
>> would already suffice here.
> 
> That's what I was doing here in modify_mmio, calling
> process_pending_softirqs between calls to {map/unmap}_mmio_regions.
> 
> I could leave modify_identity_mmio as-is and simply call
> {map/unmap}_mmio_regions from the vPCI header handlers, calling
> process_pending_softirqs in between. I just moved the helper because
> it avoids open-coding this again.

Oh, indeed. In that case I'd suggest wording the comment in a
less scary way.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel