Re: [Xen-devel] [PATCH v4 9/9] arm/mem_access: Walk the guest's pt in software

[Sergej Proskurin <proskurin@xxxxxxxxxxxxx>]

Hi Tamas,

[...]

>> +        if ( guest_walk_tables(v, gva, &ipa, &perms) < 0 )
>> +            /*
>> +             * The software gva to ipa translation can still fail, e.g., if 
>> the
>> +             * gva is not mapped.
>> +             */
> 
> If you end up sending another round of the series, I would prefer to
> see this comment before the if statement (but I wouldn't hold up the
> series over that).
> 
>> +            goto err;
>> +

Alright, will do. Thanks!

Cheers,
~Sergej

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel