Re: [Xen-devel] [PATCH] libxc: add xc_domain_add_to_physmap_batch to wrap XENMEM_add_to_physmap_batch

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.06.17 at 06:55, <blackskygg@xxxxxxxxx> wrote:
> currently there is no wrapper for XENMEM_add_to_physmap_batch in libxc.
> add a wrapper to do that.

It may help acceptance if you say why all of the sudden a wrapper
is needed.

> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -1372,6 +1372,15 @@ int xc_domain_add_to_physmap(xc_interface *xch,
>                               unsigned long idx,
>                               xen_pfn_t gpfn);
>  
> +int xc_domain_add_to_physmap_batch(xc_interface *xch,
> +                                   uint32_t domid,
> +                                   uint32_t foreign_domid,

I'm not exactly sure what the libxc coding rules are, but I'd expect
these both to be domid_t, ...

> +                                   unsigned int space,
> +                                   uint16_t size,

... this one to be unsigned int, ...

> +                                   xen_ulong_t *idxs,
> +                                   xen_pfn_t *gfpns,

... and these two to be pointers to const.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel