Re: [Xen-devel] [PATCH 2/2] xen/arm: lpae: Fix comments coding style

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andrew,

On 15/06/2017 23:19, Andrew Cooper wrote:
> On 15/06/2017 21:30, Julien Grall wrote:
> > Also adding one missing full stop.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > ---
> >  xen/include/asm-arm/lpae.h | 45 ++++++++++++++++++++++++++++++---------------
> >  1 file changed, 30 insertions(+), 15 deletions(-)
> >
> > diff --git a/xen/include/asm-arm/lpae.h b/xen/include/asm-arm/lpae.h
> > index 1e6a68926e..6244240ca0 100644
> > --- a/xen/include/asm-arm/lpae.h
> > +++ b/xen/include/asm-arm/lpae.h
> > @@ -3,10 +3,12 @@
> >
> >  #ifndef __ASSEMBLY__
> >
> > -/* WARNING!  Unlike the Intel pagetable code, where l1 is the lowest
> > +/*
> > + * WARNING!  Unlike the Intel pagetable code, where l1 is the lowest
> As your changing the comment, it would be more correct to say "Unlike
> the x86 pagetable code".  L1 through L4 is only the Xen naming scheme;
> neither Intel nor AMD use it in their manuals.
I can do that.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel