Re: [Xen-devel] [PATCH v7] ns16550: Add support for UART parameters to be specifed with name-value pairs

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 02/06/17 00:54, Paratey, Swapnil wrote:
>
>>> Should I submit a v8 with the "CONFIG_HAS_PCI" macro specifications for
>>> the case statements? I apologize for not trying the build for ARM
>>> beforehand.
>> Yes please.
>>
>> ~Andrew
>
> Should the contents of "enum serial_param_type" and
> "static const struct serial_param_var __initconst sp_vars[]" also be
> separated
> with the CONFIG_HAS_PCI macro?

Probably, yes.  It will help prevent accidental misuse.

> Or just the parts where the code gave errors
> in the switch statement? If so, should I maintain the alphabetical
> order of
> the parameters or should I separate them into blocks based on which
> parameters
> are in the CONFIG_HAS_PCI space?

I'd keep the common parameters sorted, and the ones enclosed in
CONFIG_HAS_PCI collected together at the end.  You certainly want to
minimise the #ifdefary.

~Andrew



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel