Re: [Xen-devel] [PATCH for-next v3 06/12] x86/domain: push some code down to hvm_domain_initialise

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.06.17 at 13:10, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -635,6 +627,11 @@ int arch_domain_create(struct domain *d, unsigned int 
> domcr_flags,
>      HYPERVISOR_COMPAT_VIRT_START(d) =
>          is_pv_domain(d) ? __HYPERVISOR_COMPAT_VIRT_START : ~0u;
>  
> +    /* Need to determine if HAP is enabled before initialising paging */
> +    if ( is_hvm_domain(d) )
> +        d->arch.hvm_domain.hap_enabled =
> +            hvm_funcs.hap_supported && (domcr_flags & DOMCRF_hap);
> +
>      if ( !is_idle_domain(d) )
>      {
>          if ( (rc = paging_domain_init(d, domcr_flags)) != 0 )

But wouldn't the addition then better go into this subsequent if()?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel