Re: [Xen-devel] [PATCH for-next] tools/libxc: Drop broken xc_{get, set}_hvm_param() functions

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 31/05/17 11:35, Wei Liu wrote:
> On Mon, May 22, 2017 at 12:50:09PM +0100, Andrew Cooper wrote:
>> xc_{get,set}_hvm_param() are deprecated because they truncate their value
>> parameter in 32bit builds of libxc, and are therefore unfit for use.
>>
>> As there is only a single remaining user, switch that user over to
>> xc_hvm_param_get() and drop these functions completely.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> This broke QEMU build because QEMU uses those.

Which qemu? trad or upstream?  I didn't encounter build errors myself.

OTOH, my commit statement still stands.  These functions are provably
unfit for purpose, and need to be gotten rid of.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel