Re: [Xen-devel] [PATCH 1/2] x86: limit page type width

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.05.17 at 12:01, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 31/05/17 08:14, Jan Beulich wrote:
>> There's no reason to burn 4 bits on page type when we only have 7 types
>> (plus "none") at present. This requires changing one use of
>> PGT_shared_page, which so far assumed that the type is both a power of
>> 2 and the only type with the high bit set.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Any particular reason why you reverse the order of shared and writeable?

I've become very used to know that type 7 is "writable", and since
there was a gap at 6 it seemed reasonable to put "shared" there
instead of shifting both down by one.

> Either way, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel