Re: [Xen-devel] [PATCH for-next v3 06/22] x86/traps: move PV hypercall handlers to pv/traps.c

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 29/05/17 16:40, Jan Beulich wrote:
>>>> On 18.05.17 at 19:09, <wei.liu2@xxxxxxxxxx> wrote:
>> The following handlers are moved:
>> 1. do_set_trap_table
> This one makes sense to move to pv/traps.c, but ...
>
>> 2. do_set_debugreg
>> 3. do_get_debugreg
>> 4. do_fpu_taskswitch
> ... none of these do. I could see them go into pv/hypercall.c,
> but I could also see that file dealing intentionally only with
> everything hypercall related except individual handlers. Andrew,
> do you have any opinion or thoughts here?

Despite its name, traps.c deals with mostly low level exception
handling, so I am not completely convinced that do_set_trap_table()
would logically live in traps.c

I'd also prefer not to mix these into hypercall.c.  The best I can
suggest is pv/domain.c, but even that isn't great.

Sorry for being unhelpful.  I'm not sure pv/misc-hypercalls.c is a
suitable name either.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel