[Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[PATCH] tools/firmware: pass EXTRAVERSION to seabios 
build"):
> Having a fixed version string in the seabios binary is cumbersome:
>  - it is required to write something to '.version' in the toplevel
>    directory of seabios-dir-remove.
>  - it is required to pass EXTRAVERSION= to make.

I can't quite parse this, but:

> The latter is impossible without this change. For some reason an 'export
> EXTRAVERSION=something' prior to 'make tools' is not sufficient. It has
> to be passed in as cmdline option to make.

This seems like a real problem which should be improved.  But maybe we
should use Xen's EXTRAVERSION by default ?

> +SEABIOS_EXTRAVERSION ?= "-prebuilt.xen.org"

I think this is a rather odd default value.  This image is precisely
not prebuild, for example.  Also I don't think a domain name is really
the right thing here.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel