Re: [Xen-devel] [PATCH 5/7] osstest: introduce a FreeBSD build script

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("Re: [PATCH 5/7] osstest: introduce a FreeBSD build 
script"):
> On Tue, May 23, 2017 at 06:58:59PM +0100, Ian Jackson wrote:
> > Suppose we have ts-freebsd-build set
> >     path_freebsddist=$stash/build/freebsd/
> > and have it put the files in there with fixed, known, names
> >     path_freebsddist=$stash/build/freebsd/image
> >     path_freebsddist=$stash/build/freebsd/manifest
> >     path_freebsddist=$stash/build/freebsd/kernel.sets
> >     path_freebsddist=$stash/build/freebsd/base.sets
> > or something ?
> > 
> > Is there a reason why that wouldn't work ?
> > 
> > The stashing process would have to take care to set the runvar only
> > after it had created all the files.
> 
> That seems fine, and then osstest would rely on the fact that
> path_freebsddist must only be set when all the files have been
> uploaded, because ts-build-check itself won't check that the files are
> there anymore.

Exactly.

> > > +# Enable DHCP on all network interfaces
> > > +echo 'ifconfig_DEFAULT="DHCP"' >> \$target/etc/rc.conf
> > 
> > Is this wise ?  We may at some point have hosts which have two network
> > interfaces connected (perhaps to the test network, or to each other,
> > or something) in which case this is probably wrong.
> 
> This just means that on the installer all the network interfaces will
> try to get a DHCP address. This is for the installer image itself, the
> installed system will only setup DHCP on the primary interface (ie:
> the one that matches the IP address at $ho->{Ip}.

OK, good.

> > There are a lot of \.  I wonder if you might find
> > <<'ENDQ'.<<END.<<'ENDQ' a useful construct.
> 
> In fact I can define two perl variables and use them instead. There's
> really no reason they have to be shell variables ($target and
> $output).

OK, I guess.  I typically prefer to avoid feeding large quantities of
sh through the perl interpolator.  What you suggest means the reader
sees a shell script full of $variable references which actually refer
to perl variables, not shell ones.  I think that's a bit confusing.

But, ultimately, up to you.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel