Re: [Xen-devel] [PATCH 3/7] osstest: fix regular expression used to match buildjob in ts-build-check

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Tue, May 23, 2017 at 04:01:33PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH 3/7] osstest: fix regular expression used to 
> match buildjob in ts-build-check"):
> > Current regular expression used to match the buildjob works correctly when 
> > the
> > buildjob runvar has the <job_name>buildjob format, but not when the format 
> > is
> > <job_name>_buildjob (the first match group is empty in this case). Change 
> > it so
> > that it works for both formats.
> 
> I think I have misled you.  Looking at the database I see there are
> runvars with names like this
> 
>   src_host_xenbuildjob
>   guests_rumpuserxenbuildjob
> 
> Ie, the part before the _ (if any), is a scope (like a host ident).
> So this patch is wrong, and also, your other patches have to use
> `freebsdbuildjob'.
> 
> Sorry :-/.

NP, it's a simple s/freebsd_buildjob/freebsdbuildjob/, now done (and this patch
dropped).

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel