Re: [Xen-devel] [PATCH 05/12 v3] xen/arm: vpl011: Add new domctl APIs to initialize/de-initialize vpl011

[Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>]

Hi Wei,


>> --- a/tools/libxl/libxl_dom.c
>> +++ b/tools/libxl/libxl_dom.c
>> @@ -688,6 +688,15 @@ static int libxl__build_dom(libxl__gc *gc, uint32_t 
>> domid,
>>          goto out;
>>      }
>>
>> +    if ( info->vuart &&
>> +         (ret = xc_dom_vpl011_init(CTX->xch,
>> +                                   domid,
>> +                                   state->console_domid,
>> +                                   dom->vuart_gfn,
>> +                                   &state->vuart_port)) != 0 ) {
>> +        LOGE(ERROR, "xc_dom_vpl011_init failed");
>> +        goto out;
>> +    }
>
> Please push this to arch-specific function.
>
libxl__arch_domain_create() seems to be a good candidate where I can
move this code. But this function does not take
libxl__domain_build_state *state as input an input parameter, which
carries information such as state->vuart_port for intializing vpl011.
Should I modify the function prototype to take that also as input?
This will require changes in the x86 code also, which is using this
function.

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel