Re: [Xen-devel] [PATCH v2 6/9] ts-xen-build: Build the livepatch test-cases

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk writes ("Re: [PATCH v2 6/9] ts-xen-build: Build the 
livepatch test-cases"):
> > or something ?
> 
> I ended up doing two patches - one to create an enable_livepatch
> (in mfi-common) to seed the jobs.
> 
> And then another to piggyback on that.
> 
> I am attaching them here (as attachment), and I think it makes
> it simpler?

Why wouldn't you simply always build the live patch if it is
available ?

I don't think this runvar-based system, where the xen version is
tested, is a very good idea.

> @@ -95,6 +96,12 @@ sub checkout () {
>         echo >>.config LIBLEAFDIR_x86_64=lib
>         echo >>.config KERNELS=''
>  END
> +               (${enable_livepatch} ? <<END : '').
> +       if test -f xen/Kconfig; then
> +               echo >>xen/.config CONFIG_LIVEPATCH=y
> +               echo >>xen/.config CONFIG_FAST_SYMBOL_LOOKUP=y
> +    fi
> +END

I see you copied this from the xsm build, but I think there is no
reason for osstest to ever build without livepatching support ?  So
this could be unconditional.  You could put it nexst to CONFIG_EXPERT
and _FEP and _VERBOSE_DEBUG.

> +    if ($enable_livepatch) {
> +        buildcmd_stamped_logged(600, 'xen', 'xenlpt', <<END,<<END,'')
> +            export XEN_ROOT=$builddir/xen
> +            export DESTDIR=$builddir/xen/dist/xenlpt
> +            export BASEDIR=$builddir/xen/xen
> +            mkdir -p \${DESTDIR}/usr/lib/debug
> +END
> +            $make_prefix make -C xen/test -f $builddir/xen/xen/Rules.mk 
> install

So here this would need to be conditional.  But it should be
conditional on whether the build can produce it, so use
target_file_exists.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel