Re: [Xen-devel] [PATCH for-4.9] x86/pagewalk: Fix determination of Protection Key access rights

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.05.17 at 18:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/mm/guest_walk.c
> +++ b/xen/arch/x86/mm/guest_walk.c
> @@ -408,7 +408,7 @@ guest_walk_tables(struct vcpu *v, struct p2m_domain *p2m,
>       * N.B. In the case that the walk ended with a superpage, the fabricated
>       * gw->l1e contains the appropriate leaf pkey.
>       */
> -    if ( (walk & PFEC_user_mode) && !(walk & PFEC_insn_fetch) &&
> +    if ( (ar & _PAGE_USER) && !(walk & PFEC_insn_fetch) &&
>           guest_pku_enabled(v) )
>      {
>          unsigned int pkey = guest_l1e_get_pkey(gw->l1e);

Perhaps the comment ahead of this could then also do with some
improvement ("user data accesses" -> "accesses to user data")?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel