[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET
- To: Eric Blake <eblake@xxxxxxxxxx>
- From: Markus Armbruster <armbru@xxxxxxxxxx>
- Date: Tue, 16 May 2017 10:46:57 +0200
- Cc: Peter Maydell <peter.maydell@xxxxxxxxxx>, "open list:Overall" <kvm@xxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx, Cornelia Huck <cornelia.huck@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>, Alexander Graf <agraf@xxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Stefan Weil <sw@xxxxxxxxxxx>, alistair.francis@xxxxxxxxxx, "open list:Calxeda Highbank" <qemu-arm@xxxxxxxxxx>, Jan Kiszka <jan.kiszka@xxxxxx>, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Yongbok Kim <yongbok.kim@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Paul Burton <paul.burton@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Michael Walle <michael@xxxxxxxx>, "open list:Old World" <qemu-ppc@xxxxxxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>, Aurelien Jarno <aurelien@xxxxxxxxxxx>
- Delivery-date: Tue, 16 May 2017 08:47:37 +0000
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8C181804FA
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8C181804FA
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
Eric Blake <eblake@xxxxxxxxxx> writes:
> Time to wire up all the call sites that request a shutdown or
> reset to use the enum added in the previous patch.
>
> It would have been less churn to keep the common case with no
> arguments as meaning guest-triggered, and only modified the
> host-triggered code paths, via a wrapper function, but then we'd
> still have to audit that I didn't miss any host-triggered spots;
> changing the signature forces us to double-check that I correctly
> categorized all callers.
>
> Since command line options can change whether a guest reset request
> causes an actual reset vs. a shutdown, it's easy to also add the
> information to reset requests.
>
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> Acked-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> [ppc parts]
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx> [SPARC part]
> Reviewed-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx> [s390x parts]
>
> ---
> v8: rebase later in series
That turned out nicely. Thanks!
Reviewed-by: Markus Armbruster <armbru@xxxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
