Re: [Xen-devel] [PATCH v9 01/28] ARM: GICv3: setup number of LPI bits for a GICv3 guest

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andre,

On 11/05/17 18:53, Andre Przywara wrote:
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index bd974fb..033dcee 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -400,6 +400,10 @@ typedef uint64_t xen_callback_t;
>  #define GUEST_GICV3_GICD_BASE      xen_mk_ullong(0x03001000)
>  #define GUEST_GICV3_GICD_SIZE      xen_mk_ullong(0x00010000)
>
> +/* TODO: Should this number be a tool stack decision? */
> +/* The number of interrupt ID bits a guest (not Dom0) sees. */
> +#define GUEST_GICV3_GICD_INTID_BITS     16
> +
You don't use this value in this series nor fully support DomU today. 
Please don't include unnecessary things and drop this.
>  #define GUEST_GICV3_RDIST_STRIDE   xen_mk_ullong(0x00020000)
>  #define GUEST_GICV3_RDIST_REGIONS  1
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel